This repository was archived by the owner on Apr 18, 2025. It is now read-only.
forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 391
[Feat] make supercircuit test applying l2trace #767
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8414b07
to
bc57a83
Compare
Has to disabled the doc-test in busmapping: #782 |
lispc
reviewed
Aug 17, 2023
entry in circuitbuilder
add an entry for convenient
these lines cost ~35ms. Too much. This is the reason why ccc becomes much slower. I will refactor this. inside one solution is like my previous code, use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scroll feature, this PR directly connect the l2trace generated by l2geth_util with supercircuit
It has induced some utilities inside
scroll-prover
before and some refactoring on the zktrie crate.With this PR the circuit builder in bus-mapping now support a building route from l2 trace
Notice it contains some breaking changes for scroll-prover